Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production Release 24.46.0 #2594

Merged
merged 9 commits into from
Nov 11, 2024
Merged

Production Release 24.46.0 #2594

merged 9 commits into from
Nov 11, 2024

Conversation

nihal467
Copy link
Member

Proposed Changes

  • Brief of changes made.

Associated Issue

  • Link to issue here, explain how the proposed solution will solve the reported issue/ feature request.

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

vigneshhari and others added 9 commits October 30, 2024 16:04
@vigneshhari
New RBAC Implementation (#2515)
67c63d9 
RBAC Implementation
@JohnLu2004 @sainak
Flushed care_static_data prefixed redis keys (#2572)
6143667 
Flushed care_static_data prefixed redis keys (#2572)

---------

Co-authored-by: JohnLu2004 <[email protected]>
Co-authored-by: Aakash Singh <[email protected]>
@vigneshhari
Fix bug in response
39c7aa4
@arilloid
Added a settings variable to allow configurable time periods for noti…
8d5e701 
…fication deletion (#2547)

Added NOTIFICATION_RETENTION_DAYS settings variable to allow configurable time period with default of 30 days
@vigneshhari
Fix Bug in plugin config
40d94c5
@vigneshhari
Fix Bug in plugin config
341de70
@Jacobjeevan
Added profile pic url to UserBaseMinimumSerializer (#2581)
5cba13c 
* adding profile pic url to UserBaseMinSerializer

* formatting fix

* test fix
@sainak
Update queryset references in views to avoid cached results (#2582)
d6d069e 
* update queryset references in views to avoid cached results

* fix
@rithviknishad
Merge pull request #2584 from ohcnetwork/develop
0fec828
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 25.20000% with 187 lines in your changes missing coverage. Please review.

Project coverage is 69.20%. Comparing base (b9e19fb) to head (0fec828).
Report is 29 commits behind head on production.

Files with missing lines Patch % Lines
...rity/management/commands/sync_permissions_roles.py 0.00% 46 Missing ⚠️
care/security/authorization/base.py 0.00% 40 Missing ⚠️
care/security/permissions/base.py 0.00% 39 Missing ⚠️
care/security/roles/role.py 0.00% 23 Missing ⚠️
care/security/authorization/facility.py 0.00% 13 Missing ⚠️
care/facility/tasks/redis_index.py 0.00% 8 Missing ⚠️
...e/facility/management/commands/load_redis_index.py 0.00% 6 Missing ⚠️
care/security/permissions/facility.py 0.00% 6 Missing ⚠️
care/facility/api/viewsets/patient_consultation.py 50.00% 3 Missing ⚠️
care/users/api/viewsets/plug_config.py 50.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@              Coverage Diff               @@
##           production    #2594      +/-   ##
==============================================
- Coverage       70.13%   69.20%   -0.94%     
==============================================
  Files             200      211      +11     
  Lines           11717    11944     +227     
  Branches         1187     1208      +21     
==============================================
+ Hits             8218     8266      +48     
- Misses           3123     3302     +179     
  Partials          376      376

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gigincg gigincg merged commit 7306747 into production Nov 11, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nihal467 @gigincg @vigneshhari @JohnLu2004 @arilloid @Jacobjeevan @sainak @rithviknishad